Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust spacing of quote rate in swaps #28016

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: adjust spacing of quote rate in swaps #28016

merged 2 commits into from
Oct 23, 2024

Conversation

martahj
Copy link
Contributor

@martahj martahj commented Oct 22, 2024 •
edited by github-actions bot
Loading

Description

The PR to remove the legacy swaps code inadvertently caused a misalignment of the quote rate. This PR re-aligns it to be where it is expected.

Open in GitHub Codespaces

Manual testing steps

  1. Start a swap
  2. Notice that the quote rate is back on one line and the value is left-aligned

Screenshots/Recordings

Before

Screenshot 2024-10-11 at 11 32 09 AM

After

Screenshot 2024-10-22 at 12 13 50 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

martahj
martahj commented Oct 22, 2024
View reviewed changes
ui/pages/swaps/prepare-swap-page/index.scss
@@ -263,7 +263,7 @@
}

&__exchange-rate-display {
color: var(--color-text-alternative);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value was getting overwritten in a child component so I've removed it

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 22, 2024
davibroc
davibroc approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and work fine now

@martahj martahj marked this pull request as ready for review October 22, 2024 19:27
@martahj martahj requested a review from a team as a code owner October 22, 2024 19:27
@martahj martahj added this pull request to the merge queue Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f7bc3f0]
Page Load Metrics (1856 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16102244185718086
domContentLoaded15632231182617986
load16122247185617986
domInteractive277242147
backgroundConnect982312211
firstReactRender44134812612
getState474252411
initialActions01000
loadScripts11571674134713967
setupStore106326189
uiStartup17562458204819393
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit 266990b Oct 23, 2024
76 checks passed
@martahj martahj deleted the fix/quote-rate-alignment branch October 23, 2024 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davibroc davibroc davibroc approved these changes

@micaelae micaelae micaelae approved these changes

Assignees
No one assigned
Labels
area-swaps INVALID-PR-TEMPLATE PR's body doesn't match template QA Passed release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-swaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martahj @metamaskbot @davibroc @micaelae